Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review similar strings #535

Closed
pedro-mendonca opened this issue Sep 7, 2016 · 2 comments
Closed

Review similar strings #535

pedro-mendonca opened this issue Sep 7, 2016 · 2 comments
Labels
[Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Milestone
2.2

Comments

@pedro-mendonca
Copy link
Member

There are some strings that are identical, I believe they could be merged to reduce translation work, as probably it should be the same.

A few examples:

Couldn't load translations from file!
Couldn’t load translations from file!

%s translations were added
%s translation was added (singular/plural)

Create Glossary
Create glossary

Import Originals
Import originals

Import Translations
Import translations

Not Found
Not found

Permanent link to this translation
Permalink to this translation

Permanent link to this original
Permalink to this original

Placed issue here after asking @ocean90 in slack (https://wordpress.slack.com/archives/glotpress/p1473196239000146)
pedro-mendonca added a commit to pedro-mendonca/GlotPress that referenced this issue Sep 7, 2016
@pedro-mendonca
Solve issue GlotPress#535
90da678 
Merge similar strings listed in issue GlotPress#535 to reduce strings and improve translation
pedro-mendonca added a commit to pedro-mendonca/GlotPress that referenced this issue Sep 7, 2016
@pedro-mendonca
Solve issue GlotPress#535
9f8a8da 
Merge similar strings listed in issue GlotPress#535 to reduce strings and improve translation
@pedro-mendonca pedro-mendonca mentioned this issue Sep 7, 2016
Merged
@pedro-mendonca
Copy link
Member Author

I've made the PR #536 that merges some of the above as described here:

%s translation was added (singular/plural)
Create Glossary
Import Originals
Import Translations
Not Found
Permalink to this translation
Permalink to this original

ocean90 pushed a commit that referenced this issue Sep 8, 2016
@pedro-mendonca @ocean90
Merge similar strings to reduce strings and improve translation
c2003f7 
See #535.
@pedro-mendonca
Copy link
Member Author

Thanks @ocean90 👍

@ocean90 ocean90 added this to the 2.2 milestone Sep 8, 2016
@ocean90 ocean90 added [Type] Enhancement A suggestion for improvement. [Status] In Progress Tracking issues with work in progress labels Sep 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
2.2
Development

No branches or pull requests
2 participants
@ocean90 @pedro-mendonca