Merge pull request #60 from GlodoUK/GH115206

Remove limit due to looping
GlodoUK · Jun 7, 2024 · c0daffa · c0daffa
2 parents 5e699bd + 674ef0a
commit c0daffa
Showing 1 changed file with 4 additions and 9 deletions.
diff --git a/delivery_parcelhub_whistl/models/delivery.py b/delivery_parcelhub_whistl/models/delivery.py
@@ -551,7 +551,7 @@ def whistl_cancel_shipment(self, pickings):
                 )
             picking.state = "cancel"
 
-    def _whistl_get_waiting_pickings(self, limit=100):
+    def _whistl_get_waiting_pickings(self):
         return self.env["stock.picking"].search(
             [
                 ("carrier_id", "=", self.id),
@@ -565,20 +565,15 @@ def _whistl_get_waiting_pickings(self, limit=100):
                 "|",
                 ("carrier_consignment_ref", "!=", False),
                 ("carrier_tracking_ref", "!=", False),
-            ],
-            limit=limit,  # Added this to fix timeouts etc
+            ]
         )
 
-    def whistl_tracking_state_update_scheduled(self, batch_size=100):
-        pickings = self._whistl_get_waiting_pickings(limit=batch_size)
+    def whistl_tracking_state_update_scheduled(self):
+        pickings = self._whistl_get_waiting_pickings()
         for picking in pickings:
             if picking.delivery_state in ["customer_delivered", "warehouse_delivered"]:
                 continue
             self.whistl_tracking_state_update(picking)
-        if self._whistl_get_waiting_pickings():
-            self.with_delay().whistl_tracking_state_update_scheduled(
-                batch_size=batch_size
-            )
 
     def whistl_tracking_state_update(self, picking):
         request_url = self._get_whistl_tracking_url(