Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(odoo): extraManifests was broken and didn't follow general conventions #58

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/odoo/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ $ helm install my-release glodo/odoo -f ./helm-values.yaml
| config.smtp.ssl | string | `"false"` | sets odoo configuration smtp_ssl |
| config.smtp.user | string | `"false"` | sets odoo configuration smtp_user |
| config.withoutDemo | string | `"true"` | sets odoo configuration without_demo |
| extraManifests | string | `""` | Use extraManifests (string) to add. This is run through the templating system, and may be useful to create custom additional deployments, statefulsets, etc. that need a "rollme" annotation changed to force redeployment after changes are made. |
| extraManifests | list | `[]` | Use extraManifests (list) to add |
| image.pullPolicy | string | `"IfNotPresent"` | container pullPolicy |
| image.repository | string | `"glodouk/CHANGEME"` | container image |
| image.tag | string | `""` | container tag |
Expand Down
7 changes: 4 additions & 3 deletions charts/odoo/templates/extra.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{{- if .Values.extraManifests }}
{{ tpl .Values.extraManifests }}
{{- end }}
{{ range .Values.extraManifests }}
---
{{ tpl (toYaml .) $ }}
{{ end }}
4 changes: 2 additions & 2 deletions charts/odoo/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -399,8 +399,8 @@ upgrade:
# -- customisable arguments for click-odoo-update
clickArgs: "--ignore-core-addons"

# -- Use extraManifests (string) to add. This is run through the templating system, and may be useful to create custom additional deployments, statefulsets, etc. that need a "rollme" annotation changed to force redeployment after changes are made.
extraManifests: ""
# -- Use extraManifests (list) to add
extraManifests: []

velero:
# -- enable creation of velero schedule
Expand Down