-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Daily and night fishing events incremental implementation by Chris #104
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #104 +/- ##
============================================
- Coverage 85.71% 41.83% -43.88%
============================================
Files 1 7 +6
Lines 21 337 +316
============================================
+ Hits 18 141 +123
- Misses 3 196 +193 ☔ View full report in Codecov by Sentry. |
…r oldest event only; set correct column order
…ng fishing events
…ve fishing vessel filter; include and combine night loitering events; finish overall orchestration pipeline
…in ddl move to the py code
e61e318
to
1fb1ca9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this file as well as requirements.txt could be removed. They were only required for development. I'm not sure though whether we include resources like that in the repo or should clean up?
"description": "Type of event." | ||
}, | ||
{ | ||
"name": "vessel_id", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's not the right description for vessel_id (it's for ssvid). It should be:
unique vessel identifier. Vessel IDs are an internal GFW value derived from the set of core identity characteristics for a vessel (MMSI, shipname, callsign, and IMO).
"name": "prod_shiptype", | ||
"type": "STRING", | ||
"mode": "NULLABLE", | ||
"description": "type of ship from prod eyes." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that looks like a typo or unclear. I'd say: "type of ship as determined for products".
"description": "Id of the segment involved in the event." | ||
}, | ||
{ | ||
"name": "timestamp", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically, at this point the table only contains messages (with event start and end timestamp columns). So this timestamp (and year, meters_to_prev and hours) all refer to messages and not events.
@smpiano looks good to me apart from some column descriptions. We need to decide though whether this table design is OK or whether we need to provide a separate table for products that filters for @aperdizs @rrequero we decided to create a single final fishing events table in the new incremental fishing events step. We've added the column
If you don't like either of the options we can also just provide a separate table (or view) that applies the filter. |
@Chr96er Sorry for the delay. Last week, I was focused on the VV release. Regarding your question: The publication process just execute a SELECT * FROM xxxx. In this case, if the table is product_fishing_events_v2. We copy this table to the API database engine. There are not more filters. So, in terms of the API, this column is not necessary is all the events in this table are fishing events. If we need to implement the filter in the publication process for any reason, it should be enough :) @smpiano One important thing, we decided a long time ago that all the events table must have the same schema, although they are different tables. Then, if we add this new column (prod_shiptype) to the fishing events, we should do it to all off them (gaps, encounters, port visits, ...) |
NOTE: @andres-arana please review and merge #105 before merging this. |
…-restricted-view Adds creation of the restricted view
Related with> https://globalfishingwatch.atlassian.net/browse/PIPELINE-2170