Fix PEP8

GlobalFishingWatch · Nov 22, 2024 · 2bf0406 · 2bf0406
1 parent 6eb705f
commit 2bf0406
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 55 deletions.
diff --git a/pipe_events/fishing_events_incremental.py b/pipe_events/fishing_events_incremental.py
@@ -40,7 +40,9 @@ def run(bq, params):
     params_copy = params.copy()
     params_copy["temp_table"] = temp_table
     prefix_table = f'{params["destination_dataset"]}.{params["destination_table_prefix"]}'
-    params_copy["existing_merged_fishing_events"] = f"{prefix_table}_merged" if not params["use_merged_table"] else params["use_merged_table"]
+    params_copy["existing_merged_fishing_events"] = params["use_merged_table"]
+    if not params["use_merged_table"]:
+        params_copy["existing_merged_fishing_events"] = f"{prefix_table}_merged"
     bq.create_table(
         params_copy["existing_merged_fishing_events"],
         schema_file="./assets/bigquery/fishing-events-2-merge-schema.json",

diff --git a/pipe_events/fishing_events_restricitive_view.py b/pipe_events/fishing_events_restricitive_view.py
diff --git a/pipe_events/fishing_events_restricted_view.py b/pipe_events/fishing_events_restricted_view.py
@@ -18,4 +18,5 @@ def run(bq, params):
         dest_table_description(**params),
         labels=params["labels"],
     )
+    log.info(f"The view {params['dest_lr_events']} is ready.")
     return True
diff --git a/tests/test_cli.py b/tests/test_cli.py
@@ -2,10 +2,12 @@
 import unittest.mock as utm
 import pytest
 
+
 class Args:
-    project:str = ''
-    operation:str = ''
-    test:bool = True
+
+    project: str = ''
+    operation: str = ''
+    test: bool = True
 
     def __init__(self, **kwargs):
         for k in kwargs:
@@ -17,19 +19,18 @@ class TestCli:
     @utm.patch("pipe_events.utils.bigquery.BigqueryHelper")
     def test_cli(self, mocked):
         cl = cli.Cli(Args())
-        print(cl)
-        assert cl != None
+        assert cl is not None
 
     @utm.patch("pipe_events.utils.bigquery.BigqueryHelper")
     def test_unknown_operation_main(self, mocked):
         with pytest.raises(SystemExit) as err:
-            parse = utm.MagicMock(return_value=Args())
+            utm.MagicMock(return_value=Args())
             cli.main()
         assert err.value.code == 2
 
     @utm.patch("pipe_events.utils.bigquery.BigqueryHelper")
     def test_invalid_operation_cli(self, mocked):
-        with pytest.raises(RuntimeError) as err:
+        with pytest.raises(RuntimeError):
             cl = cli.Cli(Args())
             cl.run()