-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load track speeds seperately #818
Load track speeds seperately #818
Conversation
Automatic is false. You need to set a label |
|
…ch/frontend into fishing-map/track-speed-separately
f7eb2d0
to
c0c0f5c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! I'd do a full round of testing once this is merge with resources-query-refacto
[ | ||
selectAllDataviewInstancesResolved, | ||
selectThinningConfig, | ||
selectWorkspaceStateProperty('timebarGraph'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to read the timebarGraph exists this one but I'm having this error using it:
'selectDataviewsForResourceQuerying' implicitly has type 'any' because it does not have a type annotation and is referenced directly or indirectly in its own initializer.ts(7022)
seems like we have a circular dependency so we can leave it as it is for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's the reason I used selectWorkspaceStateProperty
, not very clean but...
if (fieldsQueryIndex > -1) { | ||
query[fieldsQueryIndex] = { | ||
id: 'fields', | ||
value: 'lonlat,timestamp', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this means we are not using the dataview configuration anymore until we remove speed, isn't it?
do you thing worth it to keep it there ? or do we config it directly in the app?
Loads track speed (or any other field in theory) separately from the main track data (latlon/timestamp)
See https://globalfishingwatch.atlassian.net/browse/MAP-469