Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use _app.js instead of wrapping every page with a HoC #187

Merged
merged 2 commits into from
Jul 2, 2018

Conversation

alexanbj
Copy link
Contributor

@alexanbj alexanbj commented Jul 2, 2018

Follow MUI example of using _app.js instead of wrapping every page in a HoC.

Resolves https://github.com/GlobalDigitalLibraryio/issues/issues/380

@alexanbj alexanbj requested a review from elenaand July 2, 2018 07:50
Fixes build issue because of the branch name I chose
Copy link
Collaborator

@elenaand elenaand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alexanbj alexanbj merged commit 2e2bd38 into master Jul 2, 2018
@alexanbj alexanbj deleted the mui-provider-_app.js branch July 2, 2018 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants