-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better settings and performance #864
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llapsable"" This reverts commit d97b2d2.
By analyzing the blame information on this pull request, we identified @diegodorado, @ProgramFan and @ra100 to be potential reviewers |
I also want to fix #876 with this Pull Request. |
3b79df1
to
f65453d
Compare
Old: { LANG_OPTION: 'VALUE' } New: { LANG: { OPTION: 'VALUE' }}
Published to v0.29.0 |
Glavin001
added a commit
that referenced
this pull request
Apr 16, 2016
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Switch to using
object
type for options in Atom-Beautify's package settings.Thus allowing for collapsable setting groups. See atom/settings-view#736 for more details.
Here is what it looks like now, all organized and groups collapsed:
![image](https://cloud.githubusercontent.com/assets/1885333/13222447/533d2510-d956-11e5-8a59-3d9eedbb22ad.png)
Then you can expand all of the groups:
![image](https://cloud.githubusercontent.com/assets/1885333/13222443/4ec0262c-d956-11e5-9739-6fc16bcfc7df.png)
Does this close any currently open issues?
Closes #713.
Any other comments?
I am very excited for this. However, it will be a breaking change.
I hope to have built-in migrate so this will be seamless for users.
Checklist
Check all those that are applicable and complete.
master
branchTodo:
object
groups for each languagefallback
languages.jsbeautifyrc
{ LANG_OPTION : 'VALUE' }
to{ LANG: {OPTION:'VALUE'}}
format