Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better settings and performance #864

Merged
merged 21 commits into from
Apr 2, 2016
Merged

Better settings and performance #864

merged 21 commits into from
Apr 2, 2016

Conversation

Glavin001
Copy link
Owner

What does this implement/fix? Explain your changes.

Switch to using object type for options in Atom-Beautify's package settings.
Thus allowing for collapsable setting groups. See atom/settings-view#736 for more details.

Here is what it looks like now, all organized and groups collapsed:
image

Then you can expand all of the groups:
image

Does this close any currently open issues?

Closes #713.

Any other comments?

I am very excited for this. However, it will be a breaking change.
I hope to have built-in migrate so this will be seamless for users.

Checklist

Check all those that are applicable and complete.

  • Merged with latest master branch
  • Added examples for testing to examples/ directory
  • Travis CI passes (Mac support)
  • AppVeyor passes (Windows support)

Todo:

  • Options are now in object groups for each language
    • Language config options within language groups
    • Include options from fallback languages
    • Delete options that do not have a supported beautifier
  • Options are being extracted (tests all passing)
    • Add tests for using the package settings instead of .jsbeautifyrc
  • Documentation generation is updated to handle this new structure
  • Options are migrated automatically from { LANG_OPTION : 'VALUE' } to { LANG: {OPTION:'VALUE'}} format
  • Pre-compile the language/beautifiers config settings

@Glavin001 Glavin001 self-assigned this Mar 21, 2016
@Glavin001 Glavin001 added this to the v0.29.0 milestone Mar 21, 2016
@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @diegodorado, @ProgramFan and @ra100 to be potential reviewers

@Glavin001
Copy link
Owner Author

I also want to fix #876 with this Pull Request.

@Glavin001 Glavin001 changed the title [WIP] Better settings [WIP] Better settings and performance Mar 29, 2016
@Glavin001 Glavin001 merged commit c43556f into master Apr 2, 2016
@Glavin001
Copy link
Owner Author

Published to v0.29.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Beautify settings UX
2 participants