Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds .js to the extensions supported by the jsx language #348

Merged
merged 1 commit into from
May 20, 2015
Merged

adds .js to the extensions supported by the jsx language #348

merged 1 commit into from
May 20, 2015

Conversation

luisrudge
Copy link
Contributor

fixes #144 for good

Glavin001 added a commit that referenced this pull request May 20, 2015
Add .js to the extensions supported by the JSX language
@Glavin001 Glavin001 merged commit 60b86df into Glavin001:master May 20, 2015
@Glavin001
Copy link
Owner

This actually will not fix the problem you are having ( #144 ), however I am merging it anyway because it will not change anything.
While the addition of the js extension is not necessary, it will not break anything because the priority of the grammar supersedes the extensions ( see https://github.com/Glavin001/atom-beautify/blob/master/src/languages/index.coffee#L86 ). The JavaScript grammar will of course be default in Atom for .js unless changed by user.

Furthermore, the real bug is #353. Basically, extensions was not working, at all. I had a couple typos. It was actually only using the grammars, for which both JavaScript (JSX) and JSX are already supported.

I will be publishing fix for #353 soon, however given any extensions are effectively useless in the currently published version, I wonder: did you test this pull request? Did it work? If so, then it was something else, such as restarting Atom or updating Atom Beautify, etc, that actually is making it work for you now, as the grammars JavaScript (JSX) and JSX were already added and usable under language JSX.

Thank you for your contributions, regardless.

@Glavin001
Copy link
Owner

Published to v0.27.4

@luisrudge
Copy link
Contributor Author

Thanks for the explanation.

@luisrudge luisrudge deleted the patch-1 branch May 20, 2015 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for JSX syntax (ReactJS)
2 participants