Switch to PHP Coding Standards Fixer #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 18, 2015 21:01
|
Awesome, thank you! I am going to try to personally review this Pull Request soon (tomorrow or this weekend). First, could you enable the PHP unit tests:
This will mean that PHP beautification is now supported with tests and is tested by Travis CI automatically. Thanks again! Awesome work so far. |
enable test 1 and 2. test 3 does not seem to pass
|
Looks good to me! Absolutely awesome work! |
Glavin001
added a commit
that referenced
this pull request
Mar 20, 2015
Switch to PHP Coding Standards Fixer
|
Published to v0.23.0 |
This was referenced Mar 20, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reference to #175 I have removed PHP_Beautifier and replaced it with php-cs-fixer. This is my first attempt at working with an atom package, so hopefully I did everything correctly.