-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Docker Executable with optional Executable, PHP-CS-Fixer #2129
Conversation
@@ -49,6 +49,7 @@ class Executable | |||
.then(() => @) | |||
.catch((error) => | |||
if not @.required | |||
@verbose("Not required") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add executable name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -366,6 +367,7 @@ class HybridExecutable extends Executable | |||
|
|||
constructor: (options) -> | |||
super(options) | |||
@verbose("HybridExecutable Options", options) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add executable name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Travis failed for an unrelated issue. Merging. |
Published to v0.32.3 🎉 |
What does this implement/fix? Explain your changes.
Does this close any currently open issues?
No, I do not think so.
Any other comments?
See #1707.
Checklist
Check all those that are applicable and complete.
master
branchnpm run docs
CHANGELOG.md
under "Next" section