New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use OS EOL default for split string #2095

Closed

stevenzeck wants to merge 2 commits into Glavin001:master from stevenzeck:rubocop-windows-fix

Contributor

stevenzeck commented Mar 28, 2018

What does this implement/fix? Explain your changes.

Uses the OS default EOL character to split the string in rubocop.coffee
...

Does this close any currently open issues?

Closes #2092
...

Any other comments?

...

Checklist

Check all those that are applicable and complete.

Merged with latest master branch
Regenerate documentation with npm run docs
Add change details to CHANGELOG.md under "Next" section
Added examples for testing to examples/ directory
Travis CI passes (Mac support)
AppVeyor passes (Windows support)

stevenzeck added 2 commits

March 28, 2018 11:28


          Use OS EOL default for split string

132f702


          Remove EOL entirely from string.split

09a1c3e

Contributor Author

stevenzeck commented Mar 28, 2018

Need to take a different approach.

stevenzeck closed this

stevenzeck deleted the rubocop-windows-fix branch

March 28, 2018 18:42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet