Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option for sqlformat to re-indent #1926

Merged
merged 6 commits into from
Mar 2, 2018

Conversation

faheel
Copy link
Contributor

@faheel faheel commented Nov 3, 2017

What does this implement/fix? Explain your changes.

Added an option to either re-indent code or to preserve indentation. The SQL formatter, sqlparse, has an option for exactly this and is useful when the indentation is to be left unchanged.

Does this close any currently open issues?

No.

Any other comments?

...

Checklist

Check all those that are applicable and complete.

  • Merged with latest master branch
  • Regenerate documentation with npm run docs
  • Add change details to CHANGELOG.md under "Next" section
  • Added examples for testing to examples/ directory
  • Travis CI passes (Mac support)
  • AppVeyor passes (Windows support)

add option for sqlformat to re-indent
@stale
Copy link

stale bot commented Feb 3, 2018

This issue has been automatically marked as stale because it has not had recent activity. If this is still an issue, please add a comment. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 3, 2018
@stale stale bot removed the stale label Feb 4, 2018
@faheel
Copy link
Contributor Author

faheel commented Feb 4, 2018

@Glavin001 Do I need to add examples for this new option?

@Glavin001 Glavin001 self-requested a review March 2, 2018 00:30
@Glavin001 Glavin001 self-assigned this Mar 2, 2018
@Glavin001 Glavin001 merged commit c54a040 into Glavin001:master Mar 2, 2018
@Glavin001
Copy link
Owner

Thank you for contributing!

@Glavin001
Copy link
Owner

Published to v0.32.0

@stevenzeck stevenzeck mentioned this pull request Mar 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants