Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecation warning closing #1833 #1859

Merged
merged 1 commit into from
Oct 6, 2017
Merged

Fix deprecation warning closing #1833 #1859

merged 1 commit into from
Oct 6, 2017

Conversation

stevenzeck
Copy link
Contributor

@stevenzeck stevenzeck commented Sep 18, 2017 •
edited
Loading

What does this implement/fix? Explain your changes.

Fixes deprecation warnings for os.tmpDir() changing to os.tmpdir()
...

Does this close any currently open issues?

#1833
...

Any other comments?

...

Checklist

Check all those that are applicable and complete.

  • Merged with latest master branch
  • Regenerate documentation with npm run docs
  • Add change details to CHANGELOG.md under "Next" section
  • Added examples for testing to examples/ directory
  • Travis CI passes (Mac support)
  • AppVeyor passes (Windows support)

@Glavin001 Glavin001 self-requested a review October 6, 2017 01:54
@Glavin001 Glavin001 self-assigned this Oct 6, 2017
@Glavin001 Glavin001 merged commit dffae14 into Glavin001:master Oct 6, 2017
@stevenzeck stevenzeck deleted the tmpdirdeprecation branch October 7, 2017 00:31
@Glavin001 Glavin001 added this to the v0.35.6 milestone Oct 30, 2017
@Glavin001
Copy link
Owner

Published to v0.30.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Glavin001 Glavin001 Glavin001 approved these changes

Assignees

@Glavin001 Glavin001

Labels
deprecated-atom-api published
Projects
None yet
Milestone
v0.30.6
Development

Successfully merging this pull request may close these issues.
2 participants
@stevenzeck @Glavin001