Fix deprecation warning and Travis Ubuntu build #1840
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenzeck
changed the title
|
Going to break this out into separate requests (which is the way I should have done it initially) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Fix for #1833 and #1844
...
Does this close any currently open issues?
#1833 and #1844
...
Any other comments?
The Mac build is still failing due to an issue with ocp-indent and topkg, but this fixes the Linux/Ubuntu build. Solution taken from this comment: travis-ci/travis-ci#8378 (comment)
...
Checklist
Check all those that are applicable and complete.
masterbranchnpm run docsCHANGELOG.mdunder "Next" section