Add PHPCBF Version setting #1645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this fixes #1194 as well |
Glavin001
reviewed
May 6, 2017
| PHP: | ||
| phpcbf_path: true | ||
| phpcbf_version: true | ||
| standard: true |
There was a problem hiding this comment.
I think standard should still be the transform function from before? i.e standard: ["standard", (standard) ->..
There was a problem hiding this comment.
If PHPCS is called without a standard the PEAR standard is used any ways. If we want to default the standard to PEAR I feel it would be better to use the default property in options
There was a problem hiding this comment.
Sounds good. Let's set PEAR as default, so we are backwards compatible. Otherwise, this looks good to go!
| @@ -5874,23 +5874,41 @@ | |||
| "title": "PHPCBF Path", | |||
| "type": "string", | |||
| "default": "", | |||
| "description": "Path to the `phpcbf` CLI executable (Supported by PHP-CS-Fixer)", | |||
Glavin001
requested changes
May 6, 2017
|
Thanks for contributing! |
|
Published to v0.29.24 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This adds a setting to PHP for the PHPCBF Version.
If the PHPCBF version is 3 than it removes the
--no-patchflagDoes this close any currently open issues?
#1643
Any other comments?
The setting is defaulted to 2 so it doesn't change the current behavior
Checklist
Check all those that are applicable and complete.
masterbranchnpm run docs