Fix JS beautify on JSX and EJS #1432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Published to v0.29.17 I did not know the severity of this bug! It has caused HUGE problems for many, many users! See #1458, #1471, #1483, #136, #1452. I was waiting to publish a new release after some more Pull Requests have been merged, however this completely broke JS-Beautify. Thank you for fixing it! I have added 46d4975 to now throw an error so this cannot ever occur again! For example: |
This was referenced Jan 25, 2017
Closed
|
Nice, i'm glad it helped! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
When i tried to beautify EJS or JSX with JS Beautify, it wont work, because i forgot to add EJS and JSX on the Switch when i added it to JS Beautify options. This will fix the issue.