Add config to xml #1285
Merged
Add config to xml #1285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating before pull request, per contribution recommentation in project readme.
Fixed the "expected" file name and made the original test file more interesting.
Updated example files Fixed the "expected" file name and made the original test file more interesting.
|
@EliJDonahue, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Glavin001, @pixelbacon and @miketheman to be potential reviewers. |
Glavin001
approved these changes
May 28, 2017
There was a problem hiding this comment.
Looks good! I was initially concerned this file extension is too generic. However, .config file extension is commonly used by Microsoft for an XML-based file: https://fileinfo.com/extension/config
|
Thank you for contributing! |
|
Published to v0.29.26 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Adds support for XML files with '.config' file extension.
Does this close any currently open issues?
No, I don't believe there are any existing issues for .config support.
Any other comments?
I tried running the AppVeyor build, but I ran into an SSL error with RubyGems that I was unable to resolve. My changes are fairly minor though, so I don't anticipate the the SSL error buried any errors introduced by my changes.
If anyone is interested in the SSL error I ran into, or knows a workaround/fix, I'd be happy to finish the build testing with AppVeyor.
Checklist
Check all those that are applicable and complete.
masterbranch