Revert to working Remark version #1252
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vmuriart, thanks for your PR! By analyzing the history of the files in this pull request, we identified @greenkeeperio-bot, @Glavin001 and @miketheman to be potential reviewers. |
|
Closing. #1253 is a better solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Revert ba09880. Fixes #1196
...
Does this close any currently open issues?
Yes. Closes #1196
...
Any other comments?
I tested using v.6.0.0, v.5.1.0, v5.0.0 with no success.
...
Checklist
Check all those that are applicable and complete.
masterbranchRemark v4.2.2 is the latest compatible version. It breaks on Remark v5.0.0