Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tidy-markdown support #292

Closed
notslang opened this issue Apr 29, 2015 · 2 comments
Closed

add tidy-markdown support #292

notslang opened this issue Apr 29, 2015 · 2 comments
Assignees
@Glavin001
Labels
add-beautifier feature published
Milestone
v0.25.0

Comments

@notslang
Copy link

If you want to get rid of the pandoc dep, I wrote a markdown beautifier in pure JS: https://github.com/slang800/tidy-markdown (so it can be required via npm)
@notslang notslang mentioned this issue Apr 29, 2015
Closed
@Glavin001 Glavin001 added this to the v1.0.0 milestone Apr 29, 2015
This was referenced Apr 29, 2015
Closed
Closed
Closed
Open
@Glavin001
Copy link
Owner

I have added support / switched to tidy-markdown for the next release of Atom Beautify (see #282 ).
However I will not be able to release with tidy-markdown yet because there are a couple bugs / missing features (see notslang/tidy-markdown#7 and notslang/tidy-markdown#8) that will break Atom Beautify's Markdown backwards compatibility (tidy-markdown is not yet equal to and therefore cannot be substituted for Pandoc).
That being said, I am very pleased with tidy-markdown and it is definitely a better solution than using Pandoc. Once these two Issues above are taken care of then we are all set to release! Thank you for the great work so far!

@Glavin001 Glavin001 self-assigned this Apr 30, 2015
Glavin001 referenced this issue May 1, 2015
@Glavin001
See #282. Restructure internal API
7432334 
Done:
- Create base Beautifier class
- All Languages are separate files
- Options are separated for each language
- Beautifiers reference applicable Languages/Options
- Atom Beautify builds and tests can run
  - 19 failures out of 34 tests

TODO:
- Render Language Options to Atom Package Settings
- Support for Language fallback option namespaces
- Support for chosing from multiple applicable beautifiers
@Glavin001 Glavin001 mentioned this issue May 3, 2015
Closed
@Glavin001
Copy link
Owner

Published to v0.25.0

This is a very big release with lots of internal changes and (hopefully) no breaking changes. Please let me know if you are experiencing any unusual behaviour / breaking changes after updating. Thank you.

Glavin001 added a commit that referenced this issue May 3, 2015
@Glavin001
See #292. Add more Markdown with YAML Front Matter tests
4eed4cf
@Glavin001 Glavin001 mentioned this issue May 5, 2015
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Glavin001 Glavin001

Labels
add-beautifier feature published
Projects
None yet
Milestone
v0.25.0
Development

No branches or pull requests
2 participants
@notslang @Glavin001