PHPCBF stopped working altogether after v0.30.1. Throws 'Could not find 'PHPCBF'. The program may not be installed'

[avivais]

After last update I cannot beautify using PHPCBF anymore.
Previously, it worked "out-of-the-box", now even when setting the path explicitly it still complains about not finding the executable

Running on latest macOS Sierra (10.12.5)

debug.md

[Glavin001]

@prasadfutballer please subscribe to this Issue.

---

From #1725 (comment)

From your logs:

2017-06-19T08:17:11.568Z - debug: [] spawn done 0  PHP_CodeSniffer version 3.0.1 (stable) by Squiz (http://www.squiz.net)

2017-06-19T08:17:11.569Z - verbose: [] spawn result, returnCode 0
2017-06-19T08:17:11.569Z - verbose: [] spawn result, stdout PHP_CodeSniffer version 3.0.1 (stable) by Squiz (http://www.squiz.net)

2017-06-19T08:17:11.569Z - verbose: [] spawn result, stderr 
2017-06-19T08:17:11.569Z - info: [] Version text: PHP_CodeSniffer version 3.0.1 (stable) by Squiz (http://www.squiz.net)

2017-06-19T08:17:11.569Z - error: []  Error: Version is not valid: null
    at /home/mindset/.atom/packages/atom-beautify/src/beautifiers/executable.coffee:96:21

Note when phpcbf --version is run the response is PHP_CodeSniffer version 3.0.1 (stable) by Squiz (http://www.squiz.net). This is not being correctly handled at

atom-beautify/src/beautifiers/phpcbf.coffee

Line 18 in 908b53c

args: ['--version']

. By default (which is how it currently is configured) it will expect the response to be exactly 3.0.1.

This should be a quick fix I will have to test out tomorrow and publish a new release. Until then, please downgrade so you can still be productive and I will fix this ASAP. Thanks!

[Glavin001]

@avivais Thanks for reporting. I will be fixing this ASAP (likely tonight). Please downgrade to last working version, v0.29.26, and I will post here once a fix has been published. Thanks!

[avivais]

@Glavin001 thank you for the (very) fast response! I just updated PHPCBF via composer to 2.9.1 (stable) by Squiz (And not 3.0.1 as you mentioned).
I now get a different error:

Error parsing PHPCS response
Something went wrong attempting to parse the PHPCS output

How do you suggest I downgrade? Won't it (Beautify package that is) keep being updated automatically?

[Glavin001]

How do you suggest I downgrade? Won't it (Beautify package that is) keep being updated automatically?

I'm not familiar with any auto-updating package functionality in Atom. Maybe I missed it -- I manually choose when to update my packages.

Downgrading Atom-Beautify would be: apm install [email protected]. Let me know if that does not work.

I just updated PHPCBF via composer to 2.9.1 (stable) by Squiz (And not 3.0.1 as you mentioned).

The quote block above was from another user, who has the exact same issue, on another PHPCBF version. Atom-Beautify is having troubles parsing the version. It expects phpcbf --version to return 3.0.1 or 2.9.1 however it instead receives PHP_CodeSniffer version 3.0.1 (stable) by Squiz (http://www.squiz.net). So I will need to add support for both 😄 .

[prasadfutballer]

@avivais I actually upgraded PHPcode_sniffer to 3.0.0, then it stopped working, then tried downgrading to 2.9.0 and still had this issue. So right now i am running PHPcode_sniffer 2.6.0 whicch works perfectly with atom beautify 0.29.26

As glavin001 suggested, to download atom beautify use the command apm install [email protected] and to download phpcbf sudo pear install -f PHP_CodeSniffer-2.6.0 on an ubuntu system

[Glavin001]

Published fixes to v0.30.2

[avivais]

@Glavin001 updated to v0.30.2 and still get the "Error parsing PHPCS response". This is my updated debug.md

[Glavin001]

2017-06-21T12:59:35.674Z - error: [beautifiers/index.coffee] ReferenceError: path is not defined
at /Users/avivais/.atom/packages/atom-beautify/src/beautifiers/phpcbf.coffee:63:49

Looks like I have an error: https://github.com/Glavin001/atom-beautify/blob/master/src/beautifiers/phpcbf.coffee#L63
Missing requiring path. Will have to fix this later.

@avivais Pull requests welcome, by the way 😄 . May be quicker than me patching and retrying, since your system setup is likely differently than my own.

[avivais]

@Glavin001 point taken :)

Actually that error message was the linter, not the beautifier - Sorry on that (Though it did help discovering the path issue ;) ).

Thanks again