Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognise Fortran 2003/2008 file extensions #1703

Closed
trolley813 opened this issue Jun 4, 2017 · 3 comments
Closed

Recognise Fortran 2003/2008 file extensions #1703

trolley813 opened this issue Jun 4, 2017 · 3 comments

Comments

@trolley813
Copy link
Contributor

Related to #1036, but that time it's about Fortran 2003/2008. The Fortran beautifier currently doesn't work with .f03/.f08 files (as a workaround, changing extension to .f95 helps).

I suggest adding the "f03", "F03", "f08" and "F08" extensions into https://github.com/Glavin001/atom-beautify/blob/master/src/languages/fortran.coffee

  extensions: [
    "f90"
    "F90"
    "f95"
    "F95"
    "f03"
    "F03"
    "f08"
    "F08"    
]

P.S. Sorry I think that the change is too small for a pull request.
P.P.S. Sorry again for not following the guidelines, since it's not a bug, but a proposal, so it's no need to attach the gists etc.

@Glavin001
Copy link
Owner

P.S. Sorry I think that the change is too small for a pull request.

If you made a Pull Request instead of creating this Issue I could have simply checked Travis CI passed and merged it! 😉

P.P.S. Sorry again for not following the guidelines, since it's not a bug, but a proposal, so it's no need to attach the gists etc.

Agreed.


Since I receive many Issues proposing improvements -- like this -- I try to encourage users to contribute smaller fixes themselves and give back to the community. Otherwise I would spend all of my time making these tiny, specific changes which anyone could make, instead of spending my time working on major features which provide value to all Atom-Beautify users. This way I also provide the community with an opportunity to contribute and leverage our collective abilities for making Atom-Beautify better!

In conclusion: Pull Requests welcome! 😄 I trust you understand my position. As long as Travis CI passes, a simple PR like this will be merged quickly.

@trolley813
Copy link
Contributor Author

Created #1708 pull request fixing this issue.

Glavin001 added a commit that referenced this issue Jun 18, 2017
Added Fortran 2003/2008 extension support (fixes #1703)
@Glavin001
Copy link
Owner

Published to v0.30.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants