Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beautify breaks interpolated text variables in SCSS files #149

Closed
smlombardi opened this issue Dec 4, 2014 · 5 comments
Closed

Beautify breaks interpolated text variables in SCSS files #149

smlombardi opened this issue Dec 4, 2014 · 5 comments
Assignees

Comments

@smlombardi
Copy link

See attached animated GIF:

scss-beautify

This block breaks the code if beautified. The #{$name} must not be broken onto lines.

@mixin text-emphasis-variant($parent, $color) {
  #{$parent} {
    color: $color;
  }
  a#{$parent}:hover {
    color: darken($color, 10%);
  }
}
@Glavin001
Copy link
Owner

SCSS is handled by prettydiff.

See https://github.com/Glavin001/atom-beautify/blob/master/lib/language-options.coffee#L190-L192 and https://github.com/Glavin001/atom-beautify/blob/master/lib/langs/less-beautify.coffee#L2 for more details.

I'd recommend you forwarding this issue over to prettydiff at https://github.com/austincheney/prettydiff
and letting me know if there's anything else I can do, if they want me to update the dependency for prettydiff on Atom Beautify. Thanks!

@Glavin001 Glavin001 self-assigned this Dec 27, 2014
@Glavin001 Glavin001 added this to the My Christmas List milestone Dec 27, 2014
@Glavin001 Glavin001 removed this from the My Christmas List milestone Dec 28, 2014
@smlombardi
Copy link
Author

Posted prettydiff/prettydiff#39

On Sat, Dec 27, 2014 at 6:05 PM, Glavin Wiechert [email protected]
wrote:

SCSS is handled by prettydiff https://github.com/austincheney/prettydiff
.

See
https://github.com/Glavin001/atom-beautify/blob/master/lib/language-options.coffee#L190-L192
and
https://github.com/Glavin001/atom-beautify/blob/master/lib/langs/less-beautify.coffee#L2
for more details.

I'd recommend you forwarding this issue over to prettydiff at
https://github.com/austincheney/prettydiff
and letting me know if there's anything else I can do, if they want me to
update the dependency for prettydiff on Atom Beautify. Thanks!


Reply to this email directly or view it on GitHub
#149 (comment)
.

@lombardi-gux
Copy link

He has apparently fixed it, if you'd like to test: prettydiff/prettydiff#39 (comment)

@Glavin001
Copy link
Owner

It needs to be published to NPM and I am leaving now for a few days. I'll test and merge as soon as I get back.

@Glavin001 Glavin001 added this to the My Christmas List milestone Jan 1, 2015
Glavin001 added a commit that referenced this issue Jan 1, 2015
- SCSS Interpolated text variables
- LESS &:extend
@Glavin001
Copy link
Owner

Published to v0.18.0. Happy New Year! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants