Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 1.14 and flexibility upgrades #1

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

Pyrofab
Copy link

@Pyrofab Pyrofab commented May 12, 2019

  • Most project attributes have been moved to properties. Properties have been rearranged, the ones that are changed most often are at the top of the file. Note: I moved the project name to a property, intellij's analysis trips over it sometimes. I can revert that if you want.
  • The fabric.mod.json file has been updated to version 1, and more attributes are filled in by gradle.
  • License headers for GPL and LGPL have been added, with a templated copyright owner.
  • The group domain has been changed from com.github to io.github, as that's the website most of us actually own.
  • The mixin json files have been prepended with mixins., to 1) make their purpose more explicit and 2) let them be picked up by the minecraft dev plugin.

build.gradle Outdated Show resolved Hide resolved

# Sets default memory used for gradle commands. Can be overridden by user or command line properties.
# This is required to provide enough memory for the Minecraft decompilation process.
org.gradle.jvmargs = -Xmx5G
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5 GB is way too much, 2 at most.

gradle/wrapper/gradle-wrapper.properties Outdated Show resolved Hide resolved
src/main/resources/mixins.base_mod.client.json Outdated Show resolved Hide resolved
src/main/resources/mixins.base_mod.common.json Outdated Show resolved Hide resolved
build.gradle Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants