-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spatial and robust stats, intro documentation + Update of spatialstats.py
with new scikit-gstat
features
#159
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be a fantastic resource!! I look forward to seeing the text be more integrated with figures, schematics and the xdem API. Let me know if there's something I can do!
It replaces uses with the subsampling function in |
It's done!! 🥳 🎈 |
The two lines were this needed replacement are mentioned in the issue. So you can check that both are ok now. |
@rhugonnet, with this PR, there is now a minimum version requirement for scikit-gstat. Do you know which? If so, can you specify that in the environment file? |
@erikmannerfelt Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
EDIT PR ALMOST READY:
Partly resolves #152
Refactors
spstats
intospatialstats
for clarity and consistency with other module names (spatial_tools
will disappear soon, as discussed in Sort the mess in spatial_tools.py #157)Added documentation
Introduction
Spatial statistics
pageRobust statistics
pageNon-stationarity in elevation measurement errors
Spatial correlation in elevation measurement errors
Bias corrections
,Filters
, all added to APIAdded/Improved plotting functionalities
plot_1d_binning
,plot_2d_binning
for results ofnd_binning
plot_vgm
for results ofsample_multirange_variogram
Refined variogram sampling and implementation of random methods
sample_multirange_variogram
to wrap methods pre-sampling of Raster point (functions not available for users such as_get_pdist_variogram
,_subsample_wrapper
) with different methods (circular, ring, random).RasterEquidistantMetricSpace
method ofscikit-gstat
into a wrapper function_get_cdist_variogram
.Fits in one-line summary, but actually a lot of work:
Easier support for raster data: custom bins, user-defined maxlag, return count, etc... mmaelicke/scikit-gstat#111
Add custom bins (callable, iterable) and count property mmaelicke/scikit-gstat#112
Argument for optional model fitting mmaelicke/scikit-gstat#113
Add RasterMetricSpace for improved pairwise sampling of large 2D grids mmaelicke/scikit-gstat#114
kwargs
ofskgstat.Variogram
andskgstat.MetricSpace
can be passed, those are automatically sorted by thesample_multirange_variogram
function.random_state
to pass seeds of random sequences, in order for tests and examples to have fixed results (addedrandom_state
argument to many functions, including thesubsample_raster
function written by Amaury). The random seeds are also passed down toscikit-gstat
functions, when those use random sequences.Tests and fixes
sample_multirange_variogram
fit_sum_variogram
patches_method
, for it to run faster (@adehecq your convolution approach is probably still better, we should implement it!)TODO (just thought about it):
patches_method
patches_method
plot_vgm
when log scale is used.Spatial statistics
page.run
andnruns
arguments of sample_multirange_variogram