Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block pull requests as long as changes are requested #63

Merged
merged 4 commits into from
Apr 28, 2023

Conversation

yardenshoham
Copy link
Collaborator

@yardenshoham yardenshoham commented Apr 25, 2023

We add a new lgtm/blocked state that makes sure no pull request gets merged while it still has changes requested.

We add a new `lgtm/blocked` state that makes sure no pull request gets merged while it still has changes requested.

Signed-off-by: Yarden Shoham <[email protected]>
@silverwind
Copy link
Collaborator

I find it sometimes helpful to merge even with a block in place. Have observed that sometimes maintainers forget to clear a block, holding up a merge.

@yardenshoham
Copy link
Collaborator Author

yardenshoham commented Apr 25, 2023

I'm trying to think how to avoid what happened in go-gitea/gitea#22664, it blocked the queue and was not ready for merge

@silverwind
Copy link
Collaborator

Don't think it can really be automated. We could block merge by regular mergers, and admins could merge even with the lgtm bot failing (because of the block).

@yardenshoham
Copy link
Collaborator Author

yardenshoham commented Apr 25, 2023

I understand, maybe we should sync a few PRs in the merge queue, not only the earliest one

@yardenshoham yardenshoham deleted the block-on-change-request branch April 25, 2023 13:16
@silverwind
Copy link
Collaborator

Wouldn't have closed this yet. If admins want the merge block reflected in LGTM bot and are willing to forcibly merge long-blocked PRs that are ready, we could do it.

Otherwise, I guess current situation is fine. A merger should just check the blocks, ask for unblock, and if there's no response within a few days, merge.

@yardenshoham yardenshoham restored the block-on-change-request branch April 28, 2023 22:08
@yardenshoham yardenshoham reopened this Apr 28, 2023
@yardenshoham yardenshoham changed the title Block pull requests if as long as changes are requested Block pull requests as long as changes are requested Apr 28, 2023
@yardenshoham yardenshoham merged commit 9d6262d into main Apr 28, 2023
@yardenshoham yardenshoham deleted the block-on-change-request branch April 28, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants