Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove buildserver output argument from GitVersion tool as it's duplicating the actions behavior #1380

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

arturcic
Copy link
Member

@arturcic arturcic commented Dec 9, 2024

Removed the '/output buildserver' argument from the gitversion tool execution. Updated all related unit tests to reflect this change, ensuring consistency and correctness across different configurations.

@arturcic arturcic added this to the v3.x milestone Dec 9, 2024
…cating the actions behavior

Removed the '/output buildserver' argument from the `gitversion` tool execution. Updated all related unit tests to reflect this change, ensuring consistency and correctness across different configurations.
@arturcic arturcic merged commit 62f3036 into GitTools:main Dec 9, 2024
13 checks passed
Copy link
Contributor

mergify bot commented Dec 9, 2024

Thank you @arturcic for your contribution!

@arturcic arturcic modified the milestones: v4.x, v3.0.4 Dec 10, 2024
@gittools-bot
Copy link

🎉 This issue has been resolved in version v3.0.4 🎉
The release is available on:

Your GitReleaseManager bot 📦🚀

@WilliBarankin
Copy link

Looks like this change completely brakes Azure pipeline. Rolling back to version 3.0.3 fix the issue

@Nidolai
Copy link

Nidolai commented Dec 10, 2024

Brakes Azure pipelines for me as well.

@davidkeaveny
Copy link

I'm using the Azure DevOps GitVersion task, and this change from 3.0.3 to 3.0.4 has broken my pipelines, as it's not now setting $(Build.BuildNumber) - what setting do I need to update to restore normal functionality?

If my pipeline YAML includes the following:

stages:
- stage: Packaging
  jobs:
  - job: buildAndPackage
    steps:
    - checkout: self
      fetchDepth: '0'
    - task: gitversion/setup@3
      inputs:
        versionSpec: '5.10.x'
    - task: gitversion/execute@3
      inputs:
        useConfigFile: true
        configFilePath: 'GitVersion.yml'

Previous builds, which picked up v3.0.3 would produce the following output:

GitVersion executed successfully
Async Command Start: Update Build Number
Update build number to 1.15.0-unstable.90 for build 125299
Async Command End: Update Build Number
Finishing: Calculate version number

But today's builds, picking up v3.0.4, produce the following output:

GitVersion executed successfully
Finishing: Calculate version number

I can work around this by explicitly setting the GitVersion tool number in my pipeline YAML to v3.0.3, then my builds pass again, so it's definitely the v3.0.4 build that is breaking things for me.

@arturcic
Copy link
Member Author

@davidkeaveny that's a valid bug, I will fix it as part of the #1389

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants