Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE]: Gitversion broken when using versionSpec "6.x" #1401

Closed
2 tasks done
dbfr3qs opened this issue Dec 11, 2024 · 6 comments
Closed
2 tasks done

[ISSUE]: Gitversion broken when using versionSpec "6.x" #1401

dbfr3qs opened this issue Dec 11, 2024 · 6 comments

Comments

@dbfr3qs
Copy link

dbfr3qs commented Dec 11, 2024

Prerequisites

  • I have written a descriptive issue title
  • I have searched issues to ensure it has not already been reported

GitVersion package

GitHub Actions

What are you seeing?

Hi there, it appears that a recent release of Gitversion has broken the Gittools action when using an ambiguous spec version, e.g.:

uses: gittools/actions/gitversion/[email protected]
        with:
          versionSpec: "6.x"

Latest Gitversion release is 6.1.0.
Code causing the error to be raised here (I think, not familiar with the codebase).

Error is:

Error: Version spec '6.x' resolved as '6.1.0' does not satisfy the range '>=5.2.0 <6.1.0'.See https://github.com/GitTools/actions/blob/main/docs/versions.md for more information.

Additionally the docs reference v4 of this action as the only supporting action for gitversion 6.1.0+, but I can't see a v4 release.

We can get around it by pinning the versionSpec to 6.0.5 but just wanted to raise it.

What is expected?

Either v4 of this action is available or the docs are updated to reflect that versions of Gitversion >= 6.1.0 are not supported.

Steps to Reproduce

Try and run like so:

uses: gittools/actions/gitversion/[email protected]
        with:
          versionSpec: "6.x"

Output log or link to your CI build (if appropriate).

Error: Version spec '6.x' resolved as '6.1.0' does not satisfy the range '>=5.2.0 <6.1.0'.See https://github.com/GitTools/actions/blob/main/docs/versions.md for more information.
@arturcic
Copy link
Member

Ok, this type of issue related to 6.x and task 3.1.1 is repeated already in several places. I guess the confusion is the versions.md file which is listing v4 (which is a planned version at this moment) as supporting version 6.1.x of the GitVersion.
In my opinion the message is self-explanatory, but I guess I need to remove the v4 from the versions.md file just to avoid confusions. This repository does not have the same release timeline as the GitVersion or GitReleaseManager tools, so it's not clear why the expectation is to always use the latest version. Probable we need to update the docs and in the samples just specify the 6.0.x to avoid this issues and update the samples only when v4 is release

@dbfr3qs
Copy link
Author

dbfr3qs commented Dec 11, 2024

Yeah all good - and thanks for the prompt reply. That all makes sense, I just thought I'd let you know. FWIW I reckon if you update the versions doc that's probably enough as the error message links straight to it 👍 Thanks again @arturcic

@arturcic
Copy link
Member

#1403

@arturcic
Copy link
Member

Closed by #1403

@rcdailey
Copy link

I've jumped around a few of these issues and I see explanations but none of it makes sense to me. I don't know why 6.x shouldn't work; it was working fine before. I have no idea what all the v4 talk is about. Very disappointing that this doesn't work anymore.

rcdailey added a commit to recyclarr/recyclarr that referenced this issue Dec 22, 2024
Addresses errors introduced in the gitversion action reported in
GitTools/actions#1401.
@arturcic
Copy link
Member

rcdailey added a commit to recyclarr/recyclarr that referenced this issue Dec 22, 2024
Addresses errors introduced in the gitversion action reported in
GitTools/actions#1401.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants