Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE]: GitHub Actions - gitreleasemanager/[email protected] action.yml references milestone over tagName #1137

Closed
2 tasks done
BlairMcClelland opened this issue Jun 17, 2024 · 0 comments · Fixed by #1154

Comments

@BlairMcClelland
Copy link

BlairMcClelland commented Jun 17, 2024

Prerequisites

  • I have written a descriptive issue title
  • I have searched issues to ensure it has not already been reported

GitVersion package

GitHub Actions

What are you seeing?

When using [email protected] in Github Actions I am seeing intellisense errors in VSC due to action.yml referencing milestone when I think it should reference tagName instead?

https://github.com/GitTools/actions/blob/main/gitreleasemanager/addasset/action.yml#L23

image

Adding it anyway works okay but throws a warning as shown

image

Note that initially when using milestone only I got this error

GitReleaseManager 0.17.0+98dca9b37825946960194db5258e7fea6f1900e4
Copyright (c) 2015 - Present - GitTools Contributors
ERROR(S):
Required option 't, tagName' is missing.

What is expected?

GHA intellisense recognises tagName as a required argument and thus doesn't flag a warning in the workflow run

Steps to Reproduce

    - name: Add asset to a release
      uses: gittools/actions/gitreleasemanager/[email protected]
      with:
        token: ${{ secrets.GITHUB_TOKEN }}
        owner: ${{ github.repository_owner }}
        repository: ${{ github.event.repository.name }}
        milestone: 'v1.0.1'
        tagName: 'v1.0.1'
        assets: tool_${{ matrix.configuration }}_${{ env.GitVersion_FullSemVer }}.zip 

Output log or link to your CI build (if appropriate).

Warning: Unexpected input(s) 'tagName', valid inputs are ['owner', 'repository', 'token', 'milestone', 'assets', 'targetDirectory']
Run gittools/actions/gitreleasemanager/[email protected]
with:
token: ***
owner: org
repository: repo
milestone: v1.0.1
tagName: v1.0.1
assets: D:\a\tool\tool/tool_Release_1.0.2

arturcic added a commit to arturcic/gittools-actions that referenced this issue Jul 9, 2024
Made it consistent the fields used for the GRM actions
arturcic added a commit that referenced this issue Jul 9, 2024
#1137 - use milestone for the action field for every GRM actions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant