Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Revamp init wizard for v6 #3899

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

HHobeck
Copy link
Contributor

@HHobeck HHobeck commented Feb 6, 2024

[Improvement] Revamp init wizard for v6

Close #3229

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@arturcic
Copy link
Member

arturcic commented Feb 6, 2024

@HHobeck maybe at some point we can get back to this one, implement it from scratch taking in consideration the configuration changes we have in v6

@HHobeck
Copy link
Contributor Author

HHobeck commented Feb 6, 2024

@HHobeck maybe at some point we can get back to this one, implement it from scratch taking in consideration the configuration changes we have in v6

Of course. I just following the remarks from @asbjornu to remove it in v6 if nobody has ambition to save this feature. What is your suggestion?

@arturcic
Copy link
Member

arturcic commented Feb 6, 2024

@HHobeck maybe at some point we can get back to this one, implement it from scratch taking in consideration the configuration changes we have in v6

Of course. I just following the remarks from @asbjornu to remove it in v6 if nobody has ambition to save this feature. What is your suggestion?

I agree, it's better to remove as the init configuration was not in sync with the changes we did in the configuration part.

I still think would be nice to be able from the gitversion init to configure the workflows and all the options (now that we can Builders)

@HHobeck
Copy link
Contributor Author

HHobeck commented Feb 6, 2024

I still think would be nice to be able from the gitversion init to be able to configure the workflows and all the options (now that we can Builders)

I agree it would be nice. If you like I can help you with the design. Would you like to implement this?

@arturcic
Copy link
Member

arturcic commented Feb 6, 2024

I still think would be nice to be able from the gitversion init to be able to configure the workflows and all the options (now that we can Builders)

I agree it would be nice. If you like I can help you with the design. Would you like to implement this?

Honestly that's not on my TODO list unfortunately. I would rather focus on the new cli in next version as it's already like 2 years already from the moment we discussed.

@HHobeck
Copy link
Contributor Author

HHobeck commented Feb 6, 2024

I understand. The same on my side. I'm going to create a feature request and put it into 7.x so we have a reminder.

@arturcic arturcic merged commit 52e9155 into GitTools:main Feb 6, 2024
134 checks passed
Copy link
Contributor

mergify bot commented Feb 6, 2024

Thank you @HHobeck for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Breaking Change] Remove init wizard for v6
2 participants