Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker documentation (v5) #3859

Closed

Conversation

asbjornu
Copy link
Member

Description

Add documentation for Docker usage (rebased version of #3858).

Motivation and Context

It's currently not documented how to use GitVersion through Docker.

How Has This Been Tested?

I've executed the docs build locally.

Screenshots (if appropriate):

Docker usage documentation

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Make build.ps1 executable (chmod +x) and execute using `/usr/bin/env`
so the `PATH` is taken into consideration when finding the `pwsh`
binary.
@arturcic
Copy link
Member

arturcic commented Jan 8, 2024

@asbjornu because the v5.x branch is readonly I think the docs will get updated with the v6 release if you don't mind.

Overwise we can manually call the publish of the docs if we want to have the changes published earlier.

What do you think?

@asbjornu
Copy link
Member Author

asbjornu commented Jan 8, 2024

@arturcic, yeah. I was unsure about that. I think this is worth getting in. Is the docs publishing already possible to invoke manually, so it's not a lot of work?

@arturcic
Copy link
Member

arturcic commented Jan 8, 2024

Yes, it should be possible

@asbjornu
Copy link
Member Author

asbjornu commented Jan 8, 2024

Cool, do you approve of the changes otherwise?

@arturcic
Copy link
Member

arturcic commented Jan 8, 2024

I will check tomorrow the best option to publish the changes

@arturcic
Copy link
Member

@asbjornu I manually published from v5 https://gitversion.net/docs/usage/docker so I will close this PR

@arturcic arturcic closed this Jan 10, 2024
@asbjornu asbjornu deleted the feature/docker-docs-v5 branch January 10, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants