Changing the following classes and define the properties as immutable SemanticVersion, SemanticVersionPreReleaseTag and SemanticVersionBuildMetaData #3444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturcic
approved these changes
Mar 18, 2023
| var label = configuration.GetBranchSpecificLabel(semanticVersion.BuildMetaData.Branch, null); | ||
| semanticVersion.PreReleaseTag.Name = label ?? string.Empty; | ||
| if (semanticVersion.PreReleaseTag.Name.IsNullOrEmpty()) | ||
| // TODO: Why do we manipulating the semantic version here in the VariableProvider? The method name is GET not MANIPULATE. |
There was a problem hiding this comment.
I wonder if these TODOs are still relevant taking in consideration we compute the semantic version and return it. We could rename the method to describe the 'Compute' logic
There was a problem hiding this comment.
Okay no problem I have removed the comment.
| // What is about the separation of concern and single-responsibility principle? | ||
| semanticVersion.PreReleaseTag.Name += numberGroup.Value; | ||
| } | ||
| // TODO: Why do we manipulating the semantic version here in the VariableProvider? The method name is GET not MANIPULATE. |
There was a problem hiding this comment.
I wonder if these TODOs are still relevant taking in consideration we compute the semantic version and return it
There was a problem hiding this comment.
Okay no problem I have removed the comment.
…: SemanticVersion, SemanticVersionPreReleaseTag and SemanticVersionBuildMetaData
HHobeck
force-pushed
the
feature/3443_change-to-immutable-class-type
branch
from
b36fe33 to
2ae2c3c
Compare
|
Thank you @HHobeck for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the following classes and define the properties as immutable SemanticVersion, SemanticVersionPreReleaseTag and SemanticVersionBuildMetaData
Close #3443
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Checklist: