-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for GitHub Actions #1966
Conversation
@StanleyGoldman thanks for taking the time to implement, I'll have a look later. One think I did not see is the registration in the DI system. Please add the registration here https://github.com/GitTools/GitVersion/blob/master/src/GitVersionCore/GitVersionCoreModule.cs#L59 |
No problem. |
I'm still testing this myself, I'll let you know when I feel confident in it. |
@arturcic I'm ready for your thoughts |
@arturcic Fixed up things after your review |
@arturcic fixed up again 😅 |
Thank you so much for your contributions, @StanleyGoldman. Thanks for the time you spent 👍 |
{ | ||
} | ||
|
||
public const string EnvironmentVariableName = "GITHUB_ACTION"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be GITHUB_ACTIONS
?
GITHUB_ACTIONS | Always set to true when GitHub Actions is running the workflow. You can use this variable to differentiate when tests are being run locally or by GitHub Actions. |
---|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, are you in a position to send a PR with the fix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes #1931
Fixes #1993
Functionality:
Notes:
Using Documentation from:
https://help.github.com/en/actions/automating-your-workflow-with-github-actions/using-environment-variables#default-environment-variables
https://help.github.com/en/actions/automating-your-workflow-with-github-actions/development-tools-for-github-actions#set-an-environment-variable-set-env