Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GH-1932) Convert to Wyam for Documentation #1935

Merged
merged 32 commits into from
Dec 19, 2019

Conversation

gep13
Copy link
Member

@gep13 gep13 commented Nov 24, 2019

Still lots of work to do here, but thought I would get started...

@gep13 gep13 force-pushed the feature/GH-1932 branch 2 times, most recently from abfca01 to cf4df78 Compare November 26, 2019 19:32
@gep13
Copy link
Member Author

gep13 commented Nov 26, 2019

Progress being made...

image

@gep13
Copy link
Member Author

gep13 commented Dec 1, 2019

@arturcic @asbjornu @AdmiringWorm would you all be able to take this branch for a spin, and provide some feedback on the current status of the conversion to Wyam?

Here is the main page:

image

You should be able to run the docs locally by running:

.\build.ps1 -Target Preview-Documenation

@arturcic
Copy link
Member

@gep13 the links in the docs, do not work, they are pointing to *.md files, but if I remove the md in the url they work

Have a look here for example http://localhost:5080/GitVersion/docs/usage/usage

@arturcic arturcic added this to the 5.1.3 milestone Dec 13, 2019
@gep13
Copy link
Member Author

gep13 commented Dec 14, 2019

@arturcic I have updated the pages with the correct links. Can you have another look at this?

@arturcic
Copy link
Member

I'll have a look

@arturcic
Copy link
Member

Looks great!! So I think we can merge it. @asbjornu thoughts? Btw @gep13 how will we host/deploy the new docs? How do you do it for GRM?

@gep13
Copy link
Member Author

gep13 commented Dec 18, 2019

@arturcic I was planning on hosting this on GitHub Pages. I still have another task to add to the Wyam.cake file which would do that, but I wanted to check that everyone was happy with what I have before taking that step.

@arturcic
Copy link
Member

@arturcic I was planning on hosting this on GitHub Pages. I still have another task to add to the Wyam.cake file which would do that, but I wanted to check that everyone was happy with what I have before taking that step.

Go for it!

gep13 added 16 commits December 18, 2019 20:34
This will no longer be required once we move all docs over to Wyam.
Wyam has a couple of conventions with regard to "where" files are.
Update the folder structure to match what is expected.
Removed unit test referencing the mkdocs.yml file, as this is no longer
required.
The mkdocs.yml file is no longer required, and therefore shouldn't be
included in the sln file.
This will help with getting the docs setup, as it will allow viewing
the generated docs locally with live reload, to allow adjustments to be
made.
These were moved as part of the refactoring of the docs. This was
highlighted when the build was failing, since the included files in the
nuget packages couldn't be found.
More work is needed here, but this makes the top level pages match the
order that is in the current documentation.
The wyam.cake file was not included in the original commit, as it was
being ignored in the .gitignore file.
Add vertical ruler to make it easier to see where MD files should start
a new line, and also start controlling which rules are triggered by
markdownlint.
@asbjornu
Copy link
Member

I'd like to set this up with https://gitversion.net/ as a custom URL once it's done. GitHub Pages would be perfect. 👌

This may well break, and we won't be able to test this until merged
since it isn't meant to work on PR builds.
Should only run when running on an Azure Pipelines Windows Build Agent,
and not when it is a PR.
@arturcic arturcic marked this pull request as ready for review December 19, 2019 18:21
@arturcic arturcic merged commit 6c20b8d into GitTools:master Dec 19, 2019
@arturcic
Copy link
Member

I merged it, let's give it a try

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants