-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] 6.0 Beta 4 gitversion.msbuild with dotnet build #3832
Comments
Can you run in a cmd this piece directly? |
As I pointed out I did. Edit: ah, there are subfolders in C:\Users\chwille.nuget\packages\gitversion.msbuild\6.0.0-beta.4\tools\ - if I add net8.0 eg to the path it works. So seems not to pick entire path. |
#3832 - fix setting the TargetFramework in the GitVersion.MsBuild.targets
@arturcic is it possible to get a new beta package on nuget.org? |
@christophwille at this moment I cannot give an estimation when we get this released. There is PR that needs to be reviewed, and as far as I understand there will be a couple more related to the trunk based implementation. Let me check with @HHobeck if we can have a beta5 before he finishes his work. |
Until now there is only one PR merged to master from me which includes only preparation changes for the actual refactoring task. It is up to you:
|
@HHobeck, I think we can go with the beta5 and then your changes will get into beta6 |
🎉 This issue has been resolved in version 6.0.0-beta.5 🎉 Your GitReleaseManager bot 📦🚀 |
@christophwille may you give a try to the new beta? |
I just did - works fine (the last stumbling block was Azure DevOps doing shallow checkouts these days by default). |
When I add 6.0-b4 msbuild nuget, it works fine in VS. When executing
dotnet build
on the command line it fails when executingdotnet --roll-forward Major "C:\Users\chwille\.nuget\packages\gitversion.msbuild\6.0.0-beta.4\tools\/gitversion.dll" "C:\Workspace\src\myProject" -output file -outputfile obj\gitversion.json
(exit code 1)
When I run this separately (in the same directory as dotnet build) I get
The text was updated successfully, but these errors were encountered: