Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Document that ignore only affects the version source #2334

Closed
asbjornu opened this issue Jun 22, 2020 · 1 comment · Fixed by #2599
Closed

[Improvement] Document that ignore only affects the version source #2334

asbjornu opened this issue Jun 22, 2020 · 1 comment · Fixed by #2599
Assignees
@asbjornu
Labels
improvement
Milestone
5.6.7

Comments

@asbjornu
Copy link
Member

As written in #2122 (comment) we should document that IgnoreConfig only affects GitVersion's search for a version source, not how the ignored commit(s) are counted towards the final verison number.
@asbjornu asbjornu self-assigned this Jun 22, 2020
asbjornu added a commit to asbjornu/GitVersion that referenced this issue Feb 22, 2021
@asbjornu
Clarify ignore config to resolve GitTools#2334
0ff84a1
@asbjornu asbjornu mentioned this issue Feb 22, 2021
Merged
5 tasks
@asbjornu asbjornu added this to the 5.6.7 milestone Feb 22, 2021
@arturcic
Copy link
Member

🎉 This issue has been resolved in version 5.6.7 🎉
The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asbjornu asbjornu

Labels
improvement
Projects
None yet
Milestone
5.6.7
Development

Successfully merging a pull request may close this issue.

Refresh website asbjornu/GitVersion
2 participants
@asbjornu @arturcic