Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move packaging logic to cake #1363

Closed
dazinator opened this issue Jan 23, 2018 · 3 comments
Closed

Move packaging logic to cake #1363

dazinator opened this issue Jan 23, 2018 · 3 comments
Assignees
@dazinator

Comments

@dazinator
Copy link
Member

dazinator commented Jan 23, 2018 •
edited
Loading

In my nestandard branch, i'm moving the ILMerge and packaging mabuild logic out of the GitVersion.exe csproj file AfterBuild event, and into the cake build script instead. I expect to replace pepita with a dotnet cli pack or a nuget pack operation in the process as well..

Let me know if anyone forsees any issue with this.

The main reason I started doing this is because the AfterBuild event wasnt fired anymore since I upgraded the csproj to sdk style, and I think its probably better for all that packaging logic to be in cake anyway.

Im just raising this here for visibility.
@dazinator dazinator self-assigned this Jan 23, 2018
dazinator added a commit to dazinator/GitVersion that referenced this issue Jan 24, 2018
@dazinator
GitTools#1363 - Moved some packaging logic to cake.
505d320
dazinator added a commit to dazinator/GitVersion that referenced this issue Jan 24, 2018
@dazinator
GitTools#1363 - Moved GitVersionCore packaging logic into cake
0bf5d63 
Had to change nuget package id of GitVersionCore to be GitVersionCore rather than GitVersion - as when the <PackageId> in the csproj is GitVersion (to enable dotnet pack style) VS shows all sorts of build errors - as it seems to get confused that there is also another output in the same solution called GitVersion (i.e the exe).
dazinator added a commit to dazinator/GitVersion that referenced this issue Jan 24, 2018
@dazinator
GitTools#1363 - Moved GitVersion task packaging logic to cake.
677848e
@asbjornu
Copy link
Member

asbjornu commented Mar 9, 2018

Sounds like a good idea. The more we can do with Cake, the better, imho.

@dazinator
Copy link
Member Author

Great - I suceeded in doing this in the end.

@dazinator
Copy link
Member Author

done in #1269

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dazinator dazinator

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@asbjornu @dazinator