-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Precedence of tag and branch names when deducing version #1348
Comments
If you could provide this as a (failing) |
This issue has been automatically marked as stale because it has not had recent activity. After 30 days from now, it will be closed if no further activity occurs. Thank you for your contributions. |
@asbjornu could you have a look at this (to re-open the issue)? |
@pi3k14, if you could follow up #1348 (comment), we can perhaps move this forward. In its current state, there's not much I can do, sorry. |
This issue has been automatically marked as stale because it has not had recent activity. After 30 days from now, it will be closed if no further activity occurs. Thank you for your contributions. |
Closed by #1743 |
I think you should tune the rules for calculating version numbers a bit.
When a commit is a tip of branch and contains a tag, the tag should only have precedence if it equals the version number of the branch and contains som extra metadata (eg. 1.0.0-rc.3), or if the branch doesn't contain any version number.
Eg. develop branch is just updated and tagged with an alpha/beta number, then there is forked a release branch with a given version number. An initial build from the release branch will create a version number from the tag, since the commit are the same.
I can't se any use case where current functionality makes sense.
The text was updated successfully, but these errors were encountered: