Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReleaseNotesBuilderIntegrationTests does not work when token is missing #580

Closed
Jericho opened this issue Mar 10, 2024 · 1 comment · Fixed by #581
Closed

ReleaseNotesBuilderIntegrationTests does not work when token is missing #580

Jericho opened this issue Mar 10, 2024 · 1 comment · Fixed by #581
Assignees
@Jericho
Labels
Internal Refactoring
Milestone
0.18.0

Comments

@Jericho
Copy link
Contributor

Jericho commented Mar 10, 2024

When the authentication token is not available, the tests in the ReleaseNotesBuilderIntegrationTests class fail with a ArgumentNullException: Value cannot be null. (Parameter 'token').

This is different than how other integration tests behave. More specifically: GitHubProviderIntegrationTests and GitLabProviderIntegrationTests check for the presence of the token in their respective "one time setup" and assert that tests are inconclusive if the token is missing.

I suggest that, for the sake of consistency, ReleaseNotesBuilderIntegrationTests should behave exactly like the other integration test classes.
@Jericho Jericho mentioned this issue Mar 10, 2024
Merged
@gep13 gep13 added this to the 0.18.0 milestone Jul 10, 2024
gep13 pushed a commit to Jericho/GitReleaseManager that referenced this issue Jul 10, 2024
@Jericho @gep13
(GitTools#580) Mark the integration test as "inconclusive"
bff555d 
Updated the Release Notes Builder Integration Tests as inconclusive,
when the GitHub token is not provided. This ensures consistent behavior
with other integration tests.
gep13 added a commit that referenced this issue Jul 10, 2024
@gep13
Merge branch 'release/0.18.0'
e467873 
* release/0.18.0:
  (#580) Mark the integration test as "inconclusive"
  (test) Remove usage of Assert.AreEqual
  Bump NUnit from 3.14.0 to 4.1.0 in /src
  (test) Introduce NUnit.Analyzers
  Bump NGitLab from 6.39.0 to 6.51.1 in /src
  Bump Serilog.Sinks.Console and Serilog in /src
  Bump Microsoft.Extensions.DependencyInjection in /src
  Bump Microsoft.SourceLink.GitHub from 1.1.1 to 8.0.0 in /src
  Bump ApprovalTests from 5.9.0 to 6.0.0 in /src
  Bump Scriban from 5.9.0 to 5.10.0 in /src
  Bump Destructurama.Attributed and Serilog in /src
  Bump Microsoft.CodeAnalysis.NetAnalyzers from 7.0.4 to 8.0.0 in /src
  Bump Roslynator.Analyzers from 4.6.2 to 4.12.4 in /src
  (build) Skip running Codecov
  (#598) Upgrade Octokit reference
gittools-bot pushed a commit that referenced this issue Jul 10, 2024
@gep13
Continuous Integration Publish: e467873
141e73a 
Merge branch 'release/0.18.0'

* release/0.18.0:
  (#580) Mark the integration test as "inconclusive"
  (test) Remove usage of Assert.AreEqual
  Bump NUnit from 3.14.0 to 4.1.0 in /src
  (test) Introduce NUnit.Analyzers
  Bump NGitLab from 6.39.0 to 6.51.1 in /src
  Bump Serilog.Sinks.Console and Serilog in /src
  Bump Microsoft.Extensions.DependencyInjection in /src
  Bump Microsoft.SourceLink.GitHub from 1.1.1 to 8.0.0 in /src
  Bump ApprovalTests from 5.9.0 to 6.0.0 in /src
  Bump Scriban from 5.9.0 to 5.10.0 in /src
  Bump Destructurama.Attributed and Serilog in /src
  Bump Microsoft.CodeAnalysis.NetAnalyzers from 7.0.4 to 8.0.0 in /src
  Bump Roslynator.Analyzers from 4.6.2 to 4.12.4 in /src
  (build) Skip running Codecov
  (#598) Upgrade Octokit reference
@gittools-bot
Copy link
Contributor

🎉 This issue has been resolved in version 0.18.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

gittools-bot pushed a commit that referenced this issue Jul 10, 2024
@gep13
Continuous Integration Publish: e467873
373b086 
Merge branch 'release/0.18.0'

* release/0.18.0:
  (#580) Mark the integration test as "inconclusive"
  (test) Remove usage of Assert.AreEqual
  Bump NUnit from 3.14.0 to 4.1.0 in /src
  (test) Introduce NUnit.Analyzers
  Bump NGitLab from 6.39.0 to 6.51.1 in /src
  Bump Serilog.Sinks.Console and Serilog in /src
  Bump Microsoft.Extensions.DependencyInjection in /src
  Bump Microsoft.SourceLink.GitHub from 1.1.1 to 8.0.0 in /src
  Bump ApprovalTests from 5.9.0 to 6.0.0 in /src
  Bump Scriban from 5.9.0 to 5.10.0 in /src
  Bump Destructurama.Attributed and Serilog in /src
  Bump Microsoft.CodeAnalysis.NetAnalyzers from 7.0.4 to 8.0.0 in /src
  Bump Roslynator.Analyzers from 4.6.2 to 4.12.4 in /src
  (build) Skip running Codecov
  (#598) Upgrade Octokit reference
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jericho Jericho

Labels
Internal Refactoring
Projects
None yet
Milestone
0.18.0
Development

Successfully merging a pull request may close this issue.

Mark the Release Notes Builder integration test as "inconclusive" whe… Jericho/GitReleaseManager
3 participants
@Jericho @gep13 @gittools-bot