👷 Feat: Replace Travis w/ GitHub Actions CI #912
Conversation
|
I think we're going to scrap Snyk altogether, its functionality has been mostly replaced when GitHub bought Dependabot and integrated CVE warnings in its core product... |
|
Wishlist:
Thanks for contributing this, i'm going to see if I can improve the points above and then merge. ❤️ |
Jabster28
changed the title
|
Would you mind if I combine all of the workflow files into one and used EDIT: No worries, found a better way to do it |
|
Correct me if I'm wrong, but it seems like this gh action makes a release and immediately publishes it, and it won't allow for multiple file uploads (i.e the only binaries in the release will be the first one to finish building). Is there any way we could use something built-in, like this? |
|
Yeah, we could leverage electron-builder for this. Can we use the github token auto-generated for Actions or do I need to setup a custom one..? |
|
I'm fairly sure that the auto-generated one will work, I'll do some tests in a minute and let you know |
|
I'm getting a 403, which is (hopefully?) because I don't own the repository I forked (GitHub is weird with permissions on GH Action forks - see here), so it should work once merged since i'm using the default github token. |
|
|
|
There's 370 mentions of snyk?? where? |
|
Nope, looks good to me! |
|
Thanks a lot for helping out with this! |
* Feat: add GH Actions * forgot a sudo lol * don't need to update * upload dist once done * rename to linux.yml * rename name too * add other platforms * rename platforms * fix windows maybe? * spelled install wrong lol * add code cov * add snyk env * fix env * install npm * delete snyk workflow * don't install runtime dependencies before build script on win32 * win32 build script: respect README instructions * Fix: fix travis cli for manos & linux (GitSquared#911) * fix: cache npm * better artifact naming attempt * cache electron binaries used by electron-builder * better AppImage artifact naming * banish travis * test which platforms need python * add publishing code * move it to the right place * always publish new draft * load token * let electron-builder figure out whether to publish artifacts or not * cleanup some Snyk stuff * remove .snyk * Make a unified Workflow with multiple platforms as Jobs * remove individual os-specific workflows, use unified workflow instead Co-authored-by: Gabriel Saillard <[email protected]>
For Synk to work, you may need to add
SYNK_TOKENas one of your secrets in the repo settingsAlso, you might want to squash merge this instead of normal merging since there's a lot of commits with not-so-descriptive names (i was tired :P)