Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

Extra space at bottom of pull request status view #2229

Closed
j-f1 opened this issue Oct 4, 2018 · 2 comments
Closed

Extra space at bottom of pull request status view #2229

j-f1 opened this issue Oct 4, 2018 · 2 comments
Labels
🐛 bug Unintended behaviour within the app 🎨 design Changes to the design of the app ✨ good first issue An issue suitable for someone looking to get familiar with the codebase

Comments

@j-f1
Copy link

j-f1 commented Oct 4, 2018

Screenshot:
@rnystrom
Copy link
Member

rnystrom commented Oct 5, 2018

That’s because the floating button isn’t visible. Seems like we should add bottom inset only if we’re gonna show the button.

Sent with GitHawk

@rnystrom rnystrom added 🐛 bug Unintended behaviour within the app 🎨 design Changes to the design of the app ✨ good first issue An issue suitable for someone looking to get familiar with the codebase labels Oct 5, 2018
MichaelLutaaya added a commit to MichaelLutaaya/GitHawk that referenced this issue Oct 15, 2018
@MichaelLutaaya
Reduce bottom inset when manage button hidden
742ba38 
This fixes GitHawkApp#2229. Before this fix, the bottom inset for the collection view was the same whether or not the manage button was visible.

After this fix, the bottom inset is smaller if the manage button is hidden.
@MichaelLutaaya MichaelLutaaya mentioned this issue Oct 15, 2018
Closed
@Huddie Huddie mentioned this issue Nov 27, 2018
Open
@natharateh natharateh mentioned this issue May 26, 2019
Merged
jdisho pushed a commit that referenced this issue May 28, 2019
@jdisho
Fix extra space at the bottom of pull request status view (#2229) (#2761
344c398 
)

* notify delegate when manageButton's visibility changes

* calculate inset for manageButton dynamically

* compute threadInset using insetForManageButton

* update safe inset when manageButton's visibility changes
@jdisho
Copy link
Collaborator

jdisho commented May 28, 2019

Closed by #2761

@jdisho jdisho closed this as completed May 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🐛 bug Unintended behaviour within the app 🎨 design Changes to the design of the app ✨ good first issue An issue suitable for someone looking to get familiar with the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reduce bottom inset when manage button hidden MichaelLutaaya/GitHawk
3 participants
@rnystrom @jdisho @j-f1