-
Notifications
You must be signed in to change notification settings - Fork 385
Wireframe / design profile #2106
Comments
I'll also point out. I don't really like that bookmarks are the center icon on the tabbar. For some reason I feel it should be profile or inbox. But I wasn't really focused on that |
🔥🔥🔥@Huddie ! |
Including the following images here for quick reference against some of GitHub's current designs. It would be cool to find some fresh sources of inspiration beyond GitHub. --------------------------------------------------------------------------------------------------- --------------------------------------------------------------------------------------------------- --------------------------------------------------------------------------------------------------- --------------------------------------------------------------------------------------------------- |
@BrianLitwin I very much agree. I think the Github profile is great for web but cannot be well replicated in mobile. We should look for inspiration outside but try to maintain a familiar interface. I tried to keep the page pretty simple to start. I know it can be built out better later. |
Like the directions! I think we should start with what our information hierarchy should be before going too deep. There's so many things that could exist on the profile!
Then there are actions to take:
BrainstormBrainstorming a bit, we can slice this into buckets ranked by priority:
InspirationPulling a few images from Dribbble that drew me in: |
Here's a starter sketch file I whipped up on the flight home yesterday. We should stick to the white background style that we're now using on Issues. |
Awesome stuff! I am awfully 😍😍😍 for that centered-profile pic, circular frame.. uncluttered, elegant, placid. EG in Huddie's design in #2127 or in Antony Marshal above. |
Working off @rnystrom sketch file. Merging in some of my original thoughts. @BrianLitwin I'm not going to repost my old design as I'm pretty happy with this one taking its place. |
This weekend I started putting together a templated Sketch doc to make wireframing easier. Has colors, text, and icons in shareable components: app.zip It's not totally complete, but flagging as it might help w/ some of the design language. @Huddie some immediate thoughts:
We should boil down what the 1.0 of profile on GitHawk should do. What are the most common actions one takes when viewing someone's GitHub profile? For me, I check where they work, find their website/contact info, or see how "notable" they are (followers, big projects they own) Once we do this, we can focus on only the features that satisfy only those actions and ignore the others for later on. Otherwise we're going to add a lot of complicated features that aren't a priority (e.g. contribution activity). |
We could remove contribution activity but it happens to be on the profile page for github mobile and github web. I personally like it but I can see that it isn't necessary V1. Let me know your thoughts. |
I’d rather keep layout consistent and responsive than make device specific layouts. Too hard to manage and test. Atm devices are all laid out the same, barring the split view collapse and expansion. Sent with GitHawk |
Okay so shift the name and (soon to be added) location + email to horizontal? |
I almost missed such a great stuff here <3 @rnystrom Do you have a plan to work more on the sketch for wireframes before the weekend? |
I think one consideration is that if we're going to have tabs down the road for Repos and Starred Repos, as in Sherlouk's design, the current "Repos/Followers/Following" UI would require a significant re-design as it is now: Not trying to look ahead too much, but the more prominent that UI is in our 1.0, the trickier it will be to de-couple later on. Would also like to note, unless the Repos and Starred Repos tab are meant to look different from the Search Repos ViewController we currently use, we can reuse SearchRepoResult + SearchRepoResultSectionController, which makes those tabs very easy to build. See this view controller, which can be used for both Repos and Starred. I don't see a great reason to spend time building links to a GitHub web view when we already have so much of the architecture to display them natively already in place. |
I think the Repo/Followers/Following buttons should take you to a new view rather than have them as tabs. And the new view should be native for sure. |
Just saying that this all looks beautiful and is far better than my envelope drawing 😂 |
@cieslakdawid not really, pretty slammed the next two weeks then going out of town. Sent with GitHawk |
Any thought on finishing up this design so @BrianLitwin can tweak his profile branch? @rnystrom Any suggestions for improvement on the last design render above? |
Sure sounds good. 👌🏻 Sent with GitHawk |
@BrianLitwin looks good to me Sent with GitHawk |
@BrianLitwin I really dig it!! |
@kocheck don't feel constrained by any of the designs on this thread; there's no consensus that I know of. If you have other ideas, feel free to share them. |
Roger that! I wanted to try and take a good crack at it this weekend thanks! |
Looking forward to the design! Sounds cool Sent with GitHawk |
Hey, Folks 👋 Found some time to jump into the design file this morning. How do ya'll feel about this direction? Any comments or feedback? Design Overview 1The closest to the last posted designs. Updates
Design Overview 2This design steps out just a little further. If ya'll want me to keep going and head overboard let me know 😄 Updates
Still Designing / Next Steps
Unknowns
|
Feel free to keep exploring @kocheck but I really ❤️ Design 2. In particular I'm glad you were able to put repo/followers/following in a prominent spot. Ryan mentioned those info's are high priority when he scans profiles. I like the tabs under the Header section. What do others think? |
Totally agree moving down the tabbar looks much better +1 For second design:
I like both for the most part. I think design 1 short bio is a good place to start and design 2 can be a more fleshed our second version Sent with GitHawk |
@kocheck yo that looks SO GOOD! Love moving the bar down, very clean! @Huddie @BrianLitwin playing devil's advocate w/ myself, maybe the following/etc count shouldn't be so prominent (like option 1) since GitHub is about doing work and less about who's-who. But I think it's a useful metric for like "social capital" when meeting new people. I also really love the idea of moving the Follow into the action sheet. Remove the social aspects and keep it focused on "who is this person and what work do they do" vs social networking. I know I'm kind of churning myself here, but once I saw design 1 and compared it w/ 2, I felt like 2 is too much Twitter/Instagram and less work. Thoughts? |
I also lean towards the professional aspect of 1 vs the social emphasis of 2 as @rnystrom. |
I am more for the 1st option 😄. It points more “important” information regarding who is this person and what is doing, rather than social networking (2nd one looks like Insta). Sent with GitHawk |
Thanks for the great feedback! I will work on some comps reflecting the feedback above. @jdisho I had switched the Name/username with Location/company/website etc to help with longer names. I can do some research and swap the fields. See if I can make an edge case look good in that spot 😄 Sent with GitHawk |
Could the entire screen scroll so the tabs become a fixed header when you scroll far enough? That would mean the entire bio would be visible on all tabs and that the entire screen can be filled with repos if needed. |
@j-f1 That's what I am thinking. 👍 I might swape the Name/Username with the Location, company, and contact info again. Take advantage of the screen height. |
Traveling for the holidays, and Had an idea while in the car yesterday. Mocked it up really quick this morning. How do ya'll feel about moving the profile over to the right?
|
This is awesome! Revisiting kochecks question the other week, I think he asked about pulse activity sharing how github does it or appearing more custom, not sure if that was ever answered which way the team was leaning and curious myself... Kocheck, would you envision activity being either below pinned, or as a fourth tab, or even as an overflow option? Unlike followers which you guys realized was ultimately not a pivotal view, to me at least, activity is the most important view on a profile. |
@ijm8710 I still need to look through the GitHub docs but if we can display that data I would love to drop it at the top of the Overview Tab. 👍 If we feel good about this as a solution, what would the best way to ship, or submit it to ya'll? A Zeplin project, or should I do a Pull request to the design repo with the updated sketch file? Sent with GitHawk |
Slick 🤩!!! @kocheck |
@kocheck api.github.com/users/:user/events |
None of the images on this thread are up. Anyone have them and can upload them as a GitHub attachment? |
Designs were merged into the master sketch file I believe @tigpt |
@tigpt Let me know if you need/want a different file type and I can export that out for you. |
And images are now loading, looks like it was a network problem on my side and I assumed wrongly that they are offline. Thanks for pointing out to Design repo. |
New designs coming? Excited! |
No description provided.
The text was updated successfully, but these errors were encountered: