Add areas #77
Merged
Add areas #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- We break up creating the filter expression for the processing script into functions - This is done in order to be able to reuse the code in another processing script - And if we need to change something later we don't have to edit both scripts
- Should be faster for filtering
- The filter expression argument passed to TrajectoryLayer() becomes a
bit obsolete.
- I considered deleting it since I'm not sure we need it at all now but
I guess there's not that much harm in keeping it around, maybe we'll
need it later.
- Also by deleting it you'd need to change some existing stuff
…ent-calculation-of-average-speed-of-trajectories-crossing-two-gates
msorvoja
requested changes
Nov 11, 2024
There was a problem hiding this comment.
Looks very good overall! However, there are some issues I noticed while testing the processing algorithms:
- If class of traveler is not set, vehicle_class field in resulting line/area layer will be empty
- Speed and acceleration are not rounded to digits precision in the exported gate/area layers
- Resulting trajectory layers could be named e.g. Trajectories - Areas and Trajectories - Gates for the sake of clarity
count_trajectories_areaconnects trajectories with the same ID like this:
- Round avg speed / acceleration to a precision of 2 - If points were not filtered by class of traveler, set 'vehicle_class' to 'all'
|
@msorvoja I've addressed your comments, ready for another round. Also something I noticed and a fix is included: when exporting trajectories/gates/areas, the 'fid' field started incrementing from 0, for features the indexing starts typically from 1 so I changed that as well. |
msorvoja
approved these changes
Nov 11, 2024
msorvoja
deleted the
74-implement-calculation-of-average-speed-of-trajectories-crossing-two-gates
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #74
#76 is included.
QgsVectorLayer.materializemethod