Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set version to 1.3.3 #1538

Merged
merged 2 commits into from
May 3, 2021
Merged

Set version to 1.3.3 #1538

merged 2 commits into from
May 3, 2021

Conversation

rikhuijzer
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 1, 2021

Codecov Report

Merging #1538 (7e292ce) into master (6123752) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1538      +/-   ##
==========================================
- Coverage   89.74%   89.70%   -0.05%     
==========================================
  Files          39       39              
  Lines        4681     4670      -11     
==========================================
- Hits         4201     4189      -12     
- Misses        480      481       +1     
Impacted Files Coverage Δ
src/dataframes.jl 97.61% <ø> (ø)
src/mapping.jl 87.15% <ø> (-0.35%) ⬇️
src/terminalextensions.jl 0.00% <ø> (ø)
src/Gadfly.jl 76.79% <100.00%> (+0.30%) ⬆️
src/misc.jl 65.00% <100.00%> (ø)
src/theme.jl 70.83% <0.00%> (-2.78%) ⬇️
src/statistics.jl 95.59% <0.00%> (-0.10%) ⬇️
src/varset.jl 97.82% <0.00%> (-0.05%) ⬇️
src/scale.jl 95.63% <0.00%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36a7521...7e292ce. Read the comment docs.

NEWS.md Outdated Show resolved Hide resolved
@Mattriks
Copy link
Member

Mattriks commented May 3, 2021

I'll merge this, & I'll fix the PR numbers in the news.md myself sometime ....

@Mattriks Mattriks merged commit 03760e8 into GiovineItalia:master May 3, 2021
@rikhuijzer
Copy link
Contributor Author

I'll merge this, & I'll fix the PR numbers in the news.md myself sometime ....

Uhm...

  • The numbers are linked to the correct PRs, so that isn't broken.
  • The order is now ascending chronological like you asked, so that isn't broken.
  • If it is about only showing grammar of graphics features, then you could edit that in three clicks in the GitHub interface.

I try to learn from comments to make better PRs in the future but am unsure what to do with your comment about the PR numbers which need to be fixed.

@rikhuijzer rikhuijzer deleted the v1.3.3 branch May 4, 2021 09:39
@rikhuijzer
Copy link
Contributor Author

I'll merge this, & I'll fix the PR numbers in the news.md myself sometime ....

Maybe, the template at https://github.com/JuliaWeb/HTTP.jl/blob/master/CHANGELOG.md is nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants