Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geom.bar update 1 #1428

Merged
merged 2 commits into from
Apr 30, 2020
Merged

Geom.bar update 1 #1428

merged 2 commits into from
Apr 30, 2020

Conversation

Mattriks
Copy link
Member

@Mattriks Mattriks commented Apr 27, 2020

  • I've updated the documentation to reflect these changes
  • I've added an entry to NEWS.md
  • I've added and/or updated the unit tests
  • I've run the regression tests
  • I've built the docs and confirmed these changes don't cause new errors

This PR

Example

using DataFrames, Distributions
x = range(-4, 4, length=30)
fn1(μ,x=x) = pdf(Normal(μ, 1), x)
D = [DataFrame(x=x, y=fn1(μ), μ="$(μ)") for μ in [-1, 1]]
p1 = plot(D[1], x=:x, y=:y, Geom.bar, alpha=range(0.2,0.9, length=30))
p2 = plot(vcat(D...), x=:x, y=:y, color=, alpha=[0.5], Geom.bar(position=:identity))
a = repeat([0.75, 0.85], outer=40) # opacity
D2 = [DataFrame(x=rand(Normal(μ,1), 500), μ="$(μ)") for μ in [-1, 1]]
p3 = plot(vcat(D2...), x=:x,  color=, alpha=[a;a],
 Geom.histogram(position=:identity, bincount=40, limits=(min=-4, max=4)),
    Scale.color_discrete_manual("skyblue","moccasin"))
hstack(p1, p2, p3)

bar

@codecov-io
Copy link

codecov-io commented Apr 27, 2020

Codecov Report

Merging #1428 into master will increase coverage by 0.01%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1428      +/-   ##
==========================================
+ Coverage   89.42%   89.43%   +0.01%     
==========================================
  Files          39       39              
  Lines        4320     4325       +5     
==========================================
+ Hits         3863     3868       +5     
  Misses        457      457              
Impacted Files Coverage Δ
src/geom/bar.jl 93.57% <87.50%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a23fcdc...bb4bf65. Read the comment docs.

@Mattriks Mattriks merged commit d2b98e1 into GiovineItalia:master Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Histogram with alpha values, bars overlapping or bar highlight not same as bar color?
2 participants