Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support explicit empty arrays #1392

Merged
merged 2 commits into from
Feb 16, 2020

Conversation

Mattriks
Copy link
Member

@Mattriks Mattriks commented Jan 31, 2020

  • I've added and/or updated the unit tests
  • I've run the regression tests
  • I've built the docs and confirmed these changes don't cause new errors

This PR

Example

p1 = plot(x=[], y=[], Geom.point)
p2 = plot(x=[], y=[], Geom.line, Guide.xticks(ticks=[0,10]), Guide.yticks(ticks=[0,10]) )
hstack(p1, p2)

issue751

@codecov-io
Copy link

codecov-io commented Jan 31, 2020

Codecov Report

Merging #1392 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1392      +/-   ##
==========================================
+ Coverage   90.26%   90.31%   +0.04%     
==========================================
  Files          39       39              
  Lines        4242     4242              
==========================================
+ Hits         3829     3831       +2     
+ Misses        413      411       -2
Impacted Files Coverage Δ
src/coord.jl 91.91% <100%> (ø) ⬆️
src/statistics.jl 96.92% <100%> (ø) ⬆️
src/Gadfly.jl 79.11% <0%> (+0.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1e5474...a4d6d9a. Read the comment docs.

@Mattriks
Copy link
Member Author

Mattriks commented Feb 9, 2020

This is ready to merge.

@bjarthur bjarthur merged commit f82eef8 into GiovineItalia:master Feb 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

creating empty plot
3 participants