Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update compat to Colors v0.10 #1383

Merged
merged 1 commit into from
Jan 18, 2020
Merged

Conversation

bjarthur
Copy link
Member

tests pass locally for me. @kimikage

does this fix #1368 ?

@codecov-io
Copy link

codecov-io commented Jan 11, 2020

Codecov Report

Merging #1383 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1383   +/-   ##
=======================================
  Coverage   90.57%   90.57%           
=======================================
  Files          39       39           
  Lines        3988     3988           
=======================================
  Hits         3612     3612           
  Misses        376      376

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0ab673...4ed7d39. Read the comment docs.

@kimikage
Copy link

kimikage commented Jan 13, 2020

I guess that the cause of UndefVarError: @colorant_str not defined is a failure of package compilation. Since I don't fully understand the cause of the compilation error (i.e. since reproduction codes are not shown), I cannot say for certain. I think the issue #1368 was already fixed by PR #1377.
However, this PR definitely improves the situation. If this doesn't solve the issue #1368 then there should be something else.

@bjarthur bjarthur merged commit 8e8ce34 into GiovineItalia:master Jan 18, 2020
@bjarthur bjarthur deleted the bja/colors10 branch January 18, 2020 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UndefVarError: @colorant_str not defined
3 participants