Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

left and right triangles #1365

Merged
merged 1 commit into from
Dec 19, 2019
Merged

Conversation

Mattriks
Copy link
Member

@Mattriks Mattriks commented Dec 17, 2019

  • I've added and/or updated the unit tests
  • I've run the regression tests
  • I've updated the documentation to reflect these changes
  • I've squash'ed or fixup'ed junk commits with git-rebase
  • I've built the docs and confirmed these changes don't cause new errors

This PR:

  • adds left and right triangles

Example

shapes = [Shape.ltriangle; Shape.rtriangle; Theme().point_shapes]
D = DataFrame(x=repeat([1:5;], outer=3), y=repeat([3,2,1], inner=5), g=string.(1:15))

coord = Coord.cartesian(xmin=0, ymin=0, xmax=6, ymax=4)
p = plot(D, coord, 
    layer(x=:x, y=:y, Geom.point, Theme(default_color="black", point_size=2px)),
    layer(x=:x, y=:y, Geom.point, shape=:g, color=:g),
    Theme(point_shapes=shapes, key_position=:none, point_size=12pt, 
        plot_padding=[0mm], background_color="white")
)

Shape02a

@Mattriks
Copy link
Member Author

On Travis, julia 1.0 fails on a test (discrete_color_hue.jl) that seems unrelated to this PR.

@codecov-io
Copy link

Codecov Report

Merging #1365 into master will increase coverage by 0.39%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1365      +/-   ##
=========================================
+ Coverage    90.6%     91%   +0.39%     
=========================================
  Files          38      38              
  Lines        3961    4535     +574     
=========================================
+ Hits         3589    4127     +538     
- Misses        372     408      +36
Impacted Files Coverage Δ
src/theme.jl 69.49% <ø> (ø) ⬆️
src/shapes.jl 100% <100%> (ø) ⬆️
src/ticks.jl 90.32% <0%> (-1.49%) ⬇️
src/statistics.jl 96.28% <0%> (-0.6%) ⬇️
src/aesthetics.jl 83.15% <0%> (+1.26%) ⬆️
src/coord.jl 93.66% <0%> (+2.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb210ab...371d957. Read the comment docs.

@bjarthur bjarthur merged commit bcda0fb into GiovineItalia:master Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants