Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add TagBot #1364

Merged
merged 3 commits into from
Dec 20, 2019
Merged

add TagBot #1364

merged 3 commits into from
Dec 20, 2019

Conversation

bjarthur
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Dec 16, 2019

Codecov Report

Merging #1364 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1364      +/-   ##
==========================================
- Coverage    90.6%   90.55%   -0.06%     
==========================================
  Files          38       38              
  Lines        3961     3961              
==========================================
- Hits         3589     3587       -2     
- Misses        372      374       +2
Impacted Files Coverage Δ
src/ticks.jl 90.32% <0%> (-1.49%) ⬇️
src/aesthetics.jl 81.51% <0%> (-0.39%) ⬇️
src/shapes.jl 100% <0%> (ø) ⬆️
src/statistics.jl 96.93% <0%> (+0.04%) ⬆️
src/coord.jl 91.57% <0%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb210ab...28db43c. Read the comment docs.

@bjarthur
Copy link
Member Author

bjarthur commented Dec 19, 2019

a second commit changes CompatHelper frequency from every minute (doh!) to once per week.

@bjarthur
Copy link
Member Author

a third commit changes CI to test on julia 1.3

@@ -2,7 +2,7 @@ name: CompatHelper

on:
schedule:
- cron: '* * * * 0'
- cron: '0 0 * * 0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this once per day?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

midnight on sunday, so once per week. https://crontab.guru/#0_0_*_*_0

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a shame that both tagbot and compathelper poll. would be nice if they could be re-engineered to use interrupts.

@bjarthur
Copy link
Member Author

worth noting that the change to travis specifies "julia 1", not "julia 1.3". so when 1.4 etc is released it will automatically start testing on it. just learned this was possible from tim holy's work on indirectarrays.jl.

@bjarthur bjarthur merged commit 7c14b91 into GiovineItalia:master Dec 20, 2019
@bjarthur bjarthur deleted the bja/tagbot branch December 20, 2019 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants