Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1344 #1349

Merged
merged 1 commit into from
Nov 18, 2019
Merged

Fixes #1344 #1349

merged 1 commit into from
Nov 18, 2019

Conversation

Mattriks
Copy link
Member

@Mattriks Mattriks commented Nov 17, 2019

  • I've added and/or updated the unit tests
  • I've run the regression tests
  • I've built the docs and confirmed these changes don't cause new errors

This PR

Example

datas = Gadfly.Data(color=rand(["A","B","C","D"], 100))
scales = [Scale.color_discrete(levels=["A","B","C","D"]) ]
aes = Scale.apply_scales(scales, datas)
theme1 = Theme(key_max_columns=4)
guides = render(Guide.colorkey(), theme1, aes[1])[1]
hstack(guides.ctxs...)

issue1344

@codecov-io
Copy link

codecov-io commented Nov 17, 2019

Codecov Report

Merging #1349 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1349      +/-   ##
==========================================
- Coverage   90.62%   90.59%   -0.03%     
==========================================
  Files          37       37              
  Lines        3945     3945              
==========================================
- Hits         3575     3574       -1     
- Misses        370      371       +1
Impacted Files Coverage Δ
src/guide/keys.jl 94.73% <100%> (ø) ⬆️
src/guide.jl 90.9% <100%> (-0.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fa41cd...296fb19. Read the comment docs.

@Mattriks
Copy link
Member Author

Done.

@bjarthur bjarthur merged commit b9a124a into GiovineItalia:master Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discrete key issue
3 participants